Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📡 Add support for WalletConnect #4759

Merged
merged 31 commits into from
Feb 22, 2024
Merged

📡 Add support for WalletConnect #4759

merged 31 commits into from
Feb 22, 2024

Conversation

thesan
Copy link
Collaborator

@thesan thesan commented Feb 1, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Feb 22, 2024 0:54am
pioneer-2 ✅ Ready (Inspect) Visit Preview Feb 22, 2024 0:54am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Feb 22, 2024 0:54am

@thesan thesan marked this pull request as draft February 1, 2024 18:23
@thesan
Revert "Fix the tests"
8914ed0 
This reverts commit 12c8cbd.
kdembler
kdembler reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will review the code tomorrow. From using, all looks great. Only issue I've noticed is the same as in Atlas PR - disconnecting a wallet in Pioneer doesn't end WC session. If I select WC option again, my previous connection is restored and I don't have an option to connect different wallet through WC

@thesan
Copy link
Collaborator Author

thesan commented Feb 22, 2024

@kdembler

disconnecting a wallet in Pioneer doesn't end WC session.

I just fixed this.

FYI there was a change on this PR to show the member selection modal with the "Disconnect wallet" button when you click on "Join Now". However it was bundled with a lot of UI changes so I moved everything to #4781 (to have a more manageable PR size). So until we get to #4781, if you connect with a wallet with no memberships you can disconnect the wallet by clicking on "Add New Proposal".

@thesan thesan force-pushed the feature/walletconnect-selection branch from 34dff1e to 70fd672 Compare February 22, 2024 12:35
@thesan thesan changed the base branch from wallet-connect to dev February 22, 2024 12:46
@thesan thesan merged commit 571291c into dev Feb 22, 2024
7 checks passed
@thesan thesan deleted the feature/walletconnect-selection branch February 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdembler kdembler kdembler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesan @kdembler