cancel proposal feature #4750
Merged
cancel proposal feature #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
requested changes
Jan 30, 2024
Comment on lines
122
to
123
| proposal.votes.length === 0 && | ||
| proposal.status !== 'cancelled' && <CancelProposalButton member={active} proposalId={proposal.id} />} |
There was a problem hiding this comment.
The proposal also has to be in an active state so deciding and maybe dormant (I'm not sure if a proposal can get to the dormant state without getting voted on let's put it just in case).
packages/ui/src/proposals/modals/CancelProposal/CancelProposalModal.tsx
Outdated
Show resolved
Hide resolved
thesan
requested changes
Jan 30, 2024
Co-authored-by: Theophile Sandoz <[email protected]>
thesan
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4694