change openings reward display #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
requested changes
Jan 23, 2024
| title={`Reward per ${rewardPeriod?.toString()} blocks`} | ||
| value={rewardPeriod?.mul(opening.rewardPerBlock)} | ||
| title={'Reward per week'} | ||
| value={rewardPeriod?.mul(opening.rewardPerBlock).mul(new BN(7))} |
There was a problem hiding this comment.
The code now makes the assumption that opening.rewardPerBlock is a day , which is fine but in this case there's no need to use the api rewardPerBlock (because if the api returns something else than 14400 then rewardPerBlock * 7 won't be a week anymore).
So IMO this would be a lot clearer:
Suggested change
| value={rewardPeriod?.mul(opening.rewardPerBlock).mul(new BN(7))} | |
| value={opening.rewardPerBlock.muln(A_WEEK / MILLISECONDS_PER_BLOCK} |
Or even:
Suggested change
| value={rewardPeriod?.mul(opening.rewardPerBlock).mul(new BN(7))} | |
| value={opening.rewardPerBlock.muln(BLOCKS_PER_WEEK} |
(With BLOCKS_PER_WEEK defined as a constant somewhere).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4516