Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal-small #4676

Merged
merged 3 commits into from
Dec 8, 2023
Merged

modal-small #4676

merged 3 commits into from
Dec 8, 2023

Conversation

akiowebstar
Copy link
Contributor

@akiowebstar akiowebstar commented Dec 5, 2023 •
edited by thesan
Loading

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Dec 8, 2023 0:36am
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 8, 2023 0:36am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 8, 2023 0:36am

@chrlschwb chrlschwb added the community-dev issue suitable for community-dev pipeline label Dec 6, 2023
@chrlschwb chrlschwb requested a review from thesan December 6, 2023 14:09
thesan
thesan requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all SidePane should be widen, otherwise some of them like the candidate or membership panes which were design to be narrow will look strange:
image

For now I think only the signal SidePane should be widen (maybe by passing it a property.

thesan
thesan approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing the CR so the quickly 🙏

@thesan thesan merged commit 4644cfc into Joystream:dev Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

@chrlschwb chrlschwb chrlschwb approved these changes

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akiowebstar @thesan @chrlschwb