Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default flag-format #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default flag-format #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions katana/repl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,14 @@ def __init__(self, manager: Manager):
# Register hook to update prompt
self.register_cmdfinalization_hook(self.finalization_hook)

# Set a default flag-format if none supplied
if self.manager.flag_pattern is None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question: shouldn't this be self.manager.flag_format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that would also work. flag_pattern is the compiled regex of flag_format, so when flag_format is set using manager, flag_pattern is also being set.

flag_format = "S+{.*?}"
self.manager.set("manager", "flag-format", flag_format)
self.poutput(
f"[{Fore.BLUE}+{Style.RESET_ALL}] Using default flag-format `{flag_format}`"
)

# Start the manager
self.manager.start()

Expand Down