Update 2.1.0 internal compiler APIs doc #4631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Jan 3, 2025
| @@ -1249,16 +1249,21 @@ You can use the `KotlinAndroidExtension` in exactly the same way. | |||
|
|
|||
| ### Compiler symbols hidden from the Kotlin Gradle plugin API | |||
|
|
|||
| Starting with Kotlin 2.1.0, | |||
| you will receive a warning if you access compiler module symbols bundled within the Kotlin Gradle plugin (KGP). | |||
There was a problem hiding this comment.
I think this was technically not exact, right? The warning is based on the presence of a class file that is not bundled in KGP but build logic could still use the symbols bundled with KGP without being detected?
|
|
||
| To guard against those issues, KGP will now display a warning if `org.jetbrains.kotlin:kotlin-compiler-embeddable` is loaded in the build classpath alongside KGP. | ||
|
|
||
| As a long term fix, if you are a plugin author using `org.jetbrains.kotlin:kotlin-compiler-embeddable` classes, we recommend doing so in an isolated classloader. |
There was a problem hiding this comment.
Changed from a requirement to a recommendation. If KGP removes any dependency on compiler APIs and/or the compiler APIs become stable, it might become acceptable to do the work in the main build classpath?
Also Gradle Workers API is a possible solution but it comes with tradeoffs so it's leaving the door open to other solutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from this slack thread: https://kotlinlang.slack.com/archives/C19FD9681/p1735830883666549