Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes for KT-63421 #3925

Merged
merged 1 commit into from
Dec 6, 2023
Merged

UI changes for KT-63421 #3925

merged 1 commit into from
Dec 6, 2023

Conversation

daniCsorbaJB
Copy link
Contributor

implementing new screenshots and content for UI changes of KT-63421

@daniCsorbaJB daniCsorbaJB requested a review from a team as a code owner December 1, 2023 12:22
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😄 The screenshots just need a slight edit and I'd like the Gradle version content to be moved to a different location.

docs/images/get-started/jvm-new-project.png Outdated Show resolved Hide resolved
docs/topics/gradle/get-started-with-jvm-gradle-project.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the structure now. Thank you! Just some suggestions for improving the text now.

docs/topics/gradle/get-started-with-jvm-gradle-project.md Outdated Show resolved Hide resolved
docs/topics/gradle/get-started-with-jvm-gradle-project.md Outdated Show resolved Hide resolved
docs/topics/gradle/get-started-with-jvm-gradle-project.md Outdated Show resolved Hide resolved
docs/topics/gradle/get-started-with-jvm-gradle-project.md Outdated Show resolved Hide resolved
implementing new screenshots and content for UI changes of KT-63421

minor update

minor update

updating v-list for foojay-resolver version

updating v-list for foojay-resolver version

implementing review suggestions

implementing review suggestions - resized and added border to images and added step in a collapsible section

fixed folder structure

fixed folder structure

cropping pictures

cropping pictures

resized image

resized image

implemented suggestions

implemented suggestions

fixed right border of image

fixed right border of image

fixing right side of image

fixing right side of image

adding advanced settings screenshot in new section

adding advanced settings screenshot in new section
@sarahhaggarty sarahhaggarty merged commit 115bb47 into master Dec 6, 2023
4 checks passed
@sarahhaggarty sarahhaggarty deleted the KT-63421-UI-changes branch December 6, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants