Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put emphasis on enum entries rather than values() #3900

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Put emphasis on enum entries rather than values() #3900

merged 2 commits into from
Nov 27, 2023

Conversation

SebastianAigner
Copy link
Member

.entries is a stable part of the enum API since 1.9.0, so the featured code snippets should use it. A reference to the soft-deprecated values() function can of course remain :)

@SebastianAigner SebastianAigner requested a review from a team as a code owner November 16, 2023 02:05
@sarahhaggarty sarahhaggarty self-assigned this Nov 20, 2023
qurbonzoda
qurbonzoda approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@qurbonzoda qurbonzoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahhaggarty sarahhaggarty merged commit c09c065 into master Nov 27, 2023
4 checks passed
@sarahhaggarty sarahhaggarty deleted the SebastianAigner-patch-1 branch November 27, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qurbonzoda qurbonzoda qurbonzoda approved these changes

@sarahhaggarty sarahhaggarty sarahhaggarty approved these changes

Assignees

@sarahhaggarty sarahhaggarty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianAigner @qurbonzoda @sarahhaggarty