Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to understand the type mapping between KT and JS #3801

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Sep 23, 2023

This change replaces the bullet point list with a table, which is easier to follow and understand.

@lppedd lppedd requested a review from a team as a code owner September 23, 2023 14:42
Copy link
Contributor

@anton-bannykh anton-bannykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right

| `Any` | `Object` | |
| `Throwable` | `Error` | |
| Nullable `Type?` | `Type \| null \| undefined` | |
| All other Kotlin types | Not supported | Includes Kotlin's collections (`List`, `Set`, `Map`, etc.), and unsigned variants. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for those marked with JsExport annotation

Copy link
Collaborator

@koshachy koshachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delayed response.

Thank you for your contribution to the Kotlin documentation!

@koshachy koshachy merged commit 99c013f into JetBrains:master Nov 17, 2023
@lppedd
Copy link
Contributor Author

lppedd commented Nov 17, 2023

@koshachy no problem, and thanks for fixing that small detail!
Are you sure the first column will display decently, being it is pretty wide now?

@lppedd lppedd deleted the docs/kt-js-mapping branch November 17, 2023 14:17
@koshachy
Copy link
Collaborator

@lppedd
Yes, I've double-checked it at staging before merging :)
It is in production now and looks good!

Thank you again!

danil-pavlov added a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants