Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Update configure-sqldelight-for-data-storage.md #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asterixorobelix
Copy link

Fix spelling errors and make usage clearer

Fix spelling errors and make usage clearer
Copy link
Collaborator

@KaterinaPetrova KaterinaPetrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asterixorobelix ! Sorry for the late response and thanks for the corrections, they all seem relevant to me.
I see a few things that should be done before merging the PR:

  1. The updated code snippet for Groovy should be provided as well (section "Gradle plugin", current changes affects only Kotlin example)
  2. I agree about moving the part about "creating the DatabaseDriverFactory instance in your applications' code" into a separate section. But I'm not sure about the structure of the suggested headers. But I don't like that in the suggested structure part about "how the generator works" is divided from the part about table operations — if feels like they should be together, as all this content related to the '.sq' file. So I suggest the following structure:
    ...

Create an SQLite driver

Android driver

iOS driver

Using the driver

How the generator works

Table operations

Create ...

What do you think?

  1. Current conflicts with the master branch should be resolved

Would you like to make these changes by yourself? If not, I could take care of them — then I'll need to close a PR and create an issue in our documentation tracker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants