Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle 2.9.0-alpha03 -> 2.9.0-alpha08 #1808

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

terrakok
Copy link
Member

Release Notes

N/A

@terrakok terrakok requested a review from igordmn January 29, 2025 11:58
@terrakok terrakok force-pushed the integration-copy/lifecycle/16f8229b284/to-jb-main branch 2 times, most recently from d4b0253 to 316e330 Compare January 31, 2025 13:15
@terrakok terrakok force-pushed the integration-copy/lifecycle/16f8229b284/to-jb-main branch from 316e330 to 9fba108 Compare January 31, 2025 13:15
@terrakok terrakok merged commit 9fba108 into jb-main Jan 31, 2025
2 checks passed
@terrakok terrakok deleted the integration-copy/lifecycle/16f8229b284/to-jb-main branch January 31, 2025 13:49
igordmn added a commit to JetBrains/compose-multiplatform that referenced this pull request Feb 6, 2025
It seems we can use `merge_commit_sha` field for it - it contains the top commit that was merged/rebased/squashed in jb-main

Example:
JetBrains/compose-multiplatform-core#1808 was rebased on jb-main, and has `merge_commit_sha` of the top commit:

https://api.github.com/repos/JetBrains/compose-multiplatform-core/pulls?state=closed
```
...
    "html_url": "JetBrains/compose-multiplatform-core#1808",
    "merge_commit_sha": "9fba10809a6816f778c526ea274c1f031b7d9cab",
```

# Testing
Changelog for 1.8.0-alpha03 contains only more entries, not less
```
kotlin changelog.main.kts v1.8.0-alpha02..v1.8.0+dev2047
```

# Release Notes
N/A
igordmn added a commit to JetBrains/compose-multiplatform that referenced this pull request Feb 7, 2025
Fixes
https://youtrack.jetbrains.com/issue/CMP-7458/Changelog-script.-Change-PR-find-algorithm

It seems we can use `merge_commit_sha` field for it - it contains the
top commit that was merged/rebased/squashed to jb-main

Example:
JetBrains/compose-multiplatform-core#1808 was
rebased on jb-main, and has `merge_commit_sha` of the top commit:


https://api.github.com/repos/JetBrains/compose-multiplatform-core/pulls?state=closed
```
    ...
    "html_url": "JetBrains/compose-multiplatform-core#1808",
    "merge_commit_sha": "9fba10809a6816f778c526ea274c1f031b7d9cab",
```

![image](https://github.com/user-attachments/assets/81f80991-cf16-4bec-96d5-07cf5752737a)

# Testing
```
kotlin changelog.main.kts v1.8.0-alpha02..v1.8.0+dev2047
```
- Changelog for 1.8.0-alpha03 contains only more entries, not less
- it start to contain
JetBrains/compose-multiplatform-core#1771

# Release Notes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants