-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 11 #1803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see VERSION_1_8
in some gradle files that we actually use.
See
lifecycle/lifecycle-common/build.gradle
kruth/kruth/build.gradle
Should we update/remove it there?
Technically needs a second approval. This change changes the minimal JDK for Android targets (which was not defined anywhere). It is not the issue, as Compile SDK versions supports JDK 11 for a long time. Google Play store requires target SDK 33, which is usually equals compile SDK to have the new API. For Desktop we have minimal JDK 11 |
Updated all 1.8 to 11 (lifecycle/window/collections and other) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw it's better to investigate why the fork requires java { *Compatibility = JavaVersion.* }
in modules at all, but it isn't directly related to the update
It is required for java modules which is published as a java library but is used on android as well. |
Update java target version to 11.
Release Notes
N/A