Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 #1803

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Java 11 #1803

merged 1 commit into from
Jan 27, 2025

Conversation

terrakok
Copy link
Member

Update java target version to 11.

Release Notes

N/A

@terrakok terrakok requested a review from igordmn January 27, 2025 15:25
@terrakok terrakok changed the base branch from androidx-main to jb-main January 27, 2025 15:25
@igordmn igordmn requested a review from eymar January 27, 2025 15:27
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see VERSION_1_8 in some gradle files that we actually use.
See

lifecycle/lifecycle-common/build.gradle
kruth/kruth/build.gradle

Should we update/remove it there?

@igordmn
Copy link
Collaborator

igordmn commented Jan 27, 2025

Technically needs a second approval.

This change changes the minimal JDK for Android targets (which was not defined anywhere). It is not the issue, as Compile SDK versions supports JDK 11 for a long time. Google Play store requires target SDK 33, which is usually equals compile SDK to have the new API.

For Desktop we have minimal JDK 11

@terrakok
Copy link
Member Author

Updated all 1.8 to 11 (lifecycle/window/collections and other)

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw it's better to investigate why the fork requires java { *Compatibility = JavaVersion.* } in modules at all, but it isn't directly related to the update

@terrakok
Copy link
Member Author

It is required for java modules which is published as a java library but is used on android as well.

@terrakok terrakok merged commit 64eace9 into jb-main Jan 27, 2025
2 checks passed
@terrakok terrakok deleted the java-11 branch January 27, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants