Fix semantics keys init order issue differently #1785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d5788e7.
MatkovIvan
reviewed
Jan 20, 2025
| @@ -449,6 +449,20 @@ private fun <T> throwSemanticsGetNotSupported(): T { | |||
| ) | |||
| } | |||
|
|
|||
| @Suppress("NOTHING_TO_INLINE") | |||
| // inline to break static initialization cycle issue | |||
| internal inline fun <T> AccessibilityKey(name: String) = | |||
There was a problem hiding this comment.
There was a conflict during the last merge here. Please wait integration merging for this change
There was a problem hiding this comment.
oookay. It took some time to rediscover the root of this issue.
I reverted your previous fix after the merge for now. inline also works fine, but it requires extra comment with mentioning https://youtrack.jetbrains.com/issue/KT-65040
There was a problem hiding this comment.
I am upstreaming it in https://android-review.googlesource.com/c/platform/frameworks/support/+/3459419
After merging, I'll revert the fork changes and cherry-pick the fix
There was a problem hiding this comment.
Will do that in a separate PR, with other CL fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.