Skip to content

Commit

Permalink
JBR-6247 Update JBR-specific tests after JDK-8314823
Browse files Browse the repository at this point in the history
(cherry picked from commit 791448a)
  • Loading branch information
mkartashev committed Jan 14, 2025
1 parent 4abea96 commit abe398e
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 11 deletions.
2 changes: 1 addition & 1 deletion test/hotspot/jtreg/runtime/JBR-3923/Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class Test {
public static void main(String[] args) throws Exception {
String jarFile = System.getProperty("test.src") + "/testcase.jar";

ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-cp", jarFile,
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("-cp", jarFile,
"-XX:+UnlockDiagnosticVMOptions",
"-Xcomp",
"-XX:CompileCommand=compileonly,MainKt::test",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class LoadLibraryUnicodeTest {

public static void main(String args[]) throws Exception {
String nativePathSetting = "-Dtest.nativepath=" + getSystemProperty("test.nativepath");
ProcessBuilder pb = ProcessTools.createTestJvm(nativePathSetting, LoadLibraryUnicode.class.getName());
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(nativePathSetting, LoadLibraryUnicode.class.getName());
pb.environment().put("LC_ALL", "en_US.UTF-8");
ProcessTools.executeProcess(pb)
.outputTo(System.out)
Expand Down
16 changes: 12 additions & 4 deletions test/jdk/java/awt/Debug/X11Trace.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
* @library /test/lib
* @run main X11Trace
*/

import java.awt.AWTException;
import javax.swing.JFrame;
import javax.swing.SwingUtilities;
Expand All @@ -36,6 +37,7 @@
import java.nio.file.Paths;
import java.nio.charset.StandardCharsets;
import java.util.stream.Stream;

import jdk.test.lib.process.ProcessTools;
import jdk.test.lib.process.OutputAnalyzer;

Expand All @@ -44,13 +46,19 @@ public static void main(String[] args) throws Exception {
if (args.length > 0 && args[0].equals("runtest")) {
runTest();
} else {
OutputAnalyzer oa = ProcessTools.executeTestJvm("-Dsun.awt.x11.trace=log,timestamp,stats,td=0", X11Trace.class.getName(), "runtest");
OutputAnalyzer oa = new OutputAnalyzer(
ProcessTools.createTestJavaProcessBuilder("-Dsun.awt.x11.trace=log,timestamp,stats,td=0", X11Trace.class.getName(), "runtest")
.start());
oa.shouldContain("held AWT lock for").shouldContain("AWT Lock usage statistics").shouldHaveExitValue(0);

oa = ProcessTools.executeTestJvm("-Dsun.awt.x11.trace=log", X11Trace.class.getName(), "runtest");
oa = new OutputAnalyzer(
ProcessTools.createTestJavaProcessBuilder("-Dsun.awt.x11.trace=log", X11Trace.class.getName(), "runtest")
.start());
oa.shouldContain("held AWT lock for").shouldNotContain("AWT Lock usage statistics").shouldHaveExitValue(0);

oa = ProcessTools.executeTestJvm("-Dsun.awt.x11.trace=log,timestamp,stats,td=0,out:mylog", X11Trace.class.getName(), "runtest");
oa = new OutputAnalyzer(
ProcessTools.createTestJavaProcessBuilder("-Dsun.awt.x11.trace=log,timestamp,stats,td=0,out:mylog", X11Trace.class.getName(), "runtest")
.start());
oa.shouldHaveExitValue(0).stderrShouldBeEmpty();

final String logFileContents = Files.readString(Paths.get("mylog"));
Expand All @@ -62,7 +70,7 @@ public static void main(String[] args) throws Exception {
public static void delay(int ms) {
try {
Thread.sleep(ms);
} catch(InterruptedException e) {
} catch (InterruptedException e) {
}
}

Expand Down
4 changes: 2 additions & 2 deletions test/jdk/jb/hotspot/AbortHandler.java
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static void verifyErrorFileNotCreated(String option) throws Exception {
}
opts.add("AbortHandler");
opts.add("--test");
ProcessBuilder pb = ProcessTools.createTestJvm(opts);
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(opts);
if (pb.command().contains("-Djbr.catch.SIGABRT=true")) {
System.out.println("Test is being executed with -Djbr.catch.SIGABRT=true.");
System.out.println("Skipping verification that hs_err is not generated.");
Expand All @@ -95,7 +95,7 @@ public static void verifyErrorFileCreated() throws Exception {
opts.add("-Djbr.catch.SIGABRT=true");
opts.add("AbortHandler");
opts.add("--test");
ProcessBuilder pb = ProcessTools.createTestJvm(opts);
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(opts);
OutputAnalyzer output = new OutputAnalyzer(pb.start());

output.shouldNotContain(MARKER_TEXT);
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/jb/hotspot/JNIRefsInCrashLog.java
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static void generateAndVerifyCrashLogContents() throws Exception {
opts.add("-XX:+ErrorFileToStdout");
opts.add(JNIRefsInCrashLog.class.getName());
opts.add("--test");
ProcessBuilder pb = ProcessTools.createTestJvm(opts);
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(opts);
OutputAnalyzer output = new OutputAnalyzer(pb.start());
output.outputTo(System.out);
output.shouldContain("JNI global refs memory usage:");
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/jb/hotspot/OOMEStacksInCrashLog.java
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public static void generateAndVerifyCrashLogContents() throws Exception {
opts.add("-XX:+ErrorFileToStdout");
opts.add(OOMEStacksInCrashLog.class.getName());
opts.add("--test");
ProcessBuilder pb = ProcessTools.createTestJvm(opts);
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(opts);
OutputAnalyzer output = new OutputAnalyzer(pb.start());
output.outputTo(System.out);
output.shouldContain("OOME stack traces (most recent first)");
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/jb/java/awt/Font/LibrariesCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public static void main(String[] args) throws Exception {
Path jdkLibPath = Platform.libDir();
Files.copy(jdkLibPath.resolve(testLibName), testLibPath);

ProcessBuilder pb = ProcessTools.createTestJvm(
ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(
LibrariesCheck.class.getName(),
"runtest");

Expand Down

0 comments on commit abe398e

Please sign in to comment.