Set default table creation style to CreationStyle.CreateIfNotExists
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jabellard Dude, we can't change default behavior without a major version change. And this broke a lot of tests that would have to be adjusted. I think you'd need to wait for a major Weasel & a major Marten release to pull this off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pushing this PR to ensure that the default table creation style is
CreationStyle.CreateIfNotExists.The motivation for this change is safety. Given that applying a migration script is a process that is prone to human errors, I think it's wise to safeguard against such errors as much as possible.
With the default as
CreationStyle.DropThenCreate, if any migration script is run a second time by mistake, then tables can be dropped, resulting in a loss of data, which can be catastrophic in a production environment.