Added support for Npgsql data source #112
Merged
+596
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt passing also data source
Updated base class to accept DBConnection
Added CommandBuilder that takes NpgsqlDataSource
…ntext It seems that there's some issue (caching?) when multiple SQL statements are being called on changing database structure
oskardudycz
force-pushed
the
npgsql_data_source
branch
from
3215970 to
ac7889f
Compare
…g PostgresqlProviderTests interference
oskardudycz
force-pushed
the
npgsql_data_source
branch
from
5a65d02 to
640a257
Compare
Changed order of the extension methods parameters to extend connection, instead of builder. That should allow next extensions for data source. It'll be more clear to see responsibilities.
oskardudycz
force-pushed
the
npgsql_data_source
branch
from
af7f5c5 to
78f0976
Compare
…they're not used anymore
| } | ||
|
|
||
| migration.AssertPatchingIsValid(autoCreate); | ||
|
|
||
| logger ??= new DefaultMigrationLogger(); | ||
| await executeDelta(migration, conn, autoCreate, logger, ct).ConfigureAwait(false); | ||
| return executeDelta(migration, conn, autoCreate, logger, ct); |
There was a problem hiding this comment.
Why is this synchronous now?
There was a problem hiding this comment.
It's not synchronous, I just removed async from the method definition and removed redundant await (see. also above replacement of return; with Task.CompletedTask.
oskardudycz
force-pushed
the
npgsql_data_source
branch
from
cbceb6a to
e672528
Compare
…qlDataSource all ahead, so applied that Postgres Database management
oskardudycz
force-pushed
the
npgsql_data_source
branch
from
e672528 to
a857bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also npgsql/npgsql#5485.