Bug fix to handle index name containing upper case chars

JasperFx · Jan 13, 2025 · bcc8c25 · bcc8c25
1 parent 18125da
commit bcc8c25
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/Weasel.Postgresql.Tests/Tables/detecting_table_deltas.cs b/src/Weasel.Postgresql.Tests/Tables/detecting_table_deltas.cs
@@ -741,4 +741,18 @@ public async Task patching_and_detecting_deltas_with_computed_indexes()
 
         await AssertNoDeltasAfterPatching(table);
     }
+
+    [Fact]
+    public async Task patching_and_detecting_deltas_with_upper_case_chars_in_index_name()
+    {
+        var table = new Table("deltas.blobs");
+        table.AddColumn<string>("key").AsPrimaryKey();
+        table.AddColumn("data", "jsonb");
+
+        await CreateSchemaObjectInDatabase(table);
+
+        table.Indexes.Add(new IndexDefinition("IdxBlobsDataName") { Columns = new[] { "(data ->> 'Name')" } });
+
+        await AssertNoDeltasAfterPatching(table);
+    }
 }
diff --git a/src/Weasel.Postgresql/Tables/IndexDefinition.cs b/src/Weasel.Postgresql/Tables/IndexDefinition.cs
@@ -205,7 +205,8 @@ public string ToDDL(Table parent)
             builder.Append("CONCURRENTLY ");
         }
 
-        builder.Append(Name);
+        // Add double quotes if the index name contains upper case characters
+        builder.Append(Name.Any(char.IsUpper) ? $"\"{Name}\"" : Name);
 
         builder.Append(" ON ");
         builder.Append(parent.Identifier);
@@ -370,7 +371,7 @@ public static IndexDefinition Parse(string definition)
                     continue;
 
                 case "INDEX":
-                    var name = tokens.Dequeue();
+                    var name = tokens.Dequeue().Trim('"');
                     index = new IndexDefinition(name) { Mask = string.Empty, IsUnique = isUnique };
                     break;