chore(terra-draw): Export basic types that appear in arguments and return values

[ciscorn]

Description of Changes

This PR exports some basic types that appear in the arguments and return types of the user-facing interfaces.

Link to Issue

Resolves #439

PR Checklist

• The PR title follows the conventional commit standard
• There is a associated GitHub issue
• If I have added significant code changes, there are relevant tests
• If there are behaviour changes these are documented

[neodescis]

Should we also export TerraDrawBaseSelectMode? HexColor?

[ciscorn]

@neodescis HexColor is already exported, and TerraDrawBaseSelectMode probably doesn't appear in the public API.

[neodescis]

Right you are about HexColor. I think I was remembering HexColorStyling which does not appear to be exported. As for TerraDrawBaseSelectMode, the documentation states that you should be able to provide your own select mode. The private getSelectMode() method casts to TerraDrawBaseSelectMode. This function is internal, but it is called by public methods that rely on the methods defined in that base class. So, it seems like it should be exported in support of custom select modes; otherwise you have to hope a custom select mode's methods line up with it without type support.

[ciscorn]

@neodescis
I agree with your perspective. I’ve added TerraDrawBaseSelectMode to the export list in this PR.

[JamesLMilner]

Hey, sorry folks not ignoring this, just need a bit of free time to give it proper time to think it through - on surface makes a lot of sense however. One aspect to think about is that there is an attempt to expose types for extending Terra Draw in TerraDrawExtend. This might have been a mistake that adds extra confusion but until v2 we can't change it.

[JinIgarashi]

I think this PR is also related to #396. I found terra-draw supports types when moduleResolution = node in tsconfig.json. even you export additional types from terra-draw, the types will never work unless terra-draw supports other moduleResolution like nodenext for modern nodejs application. If we change moduleResolution to node, it can work, but it does not make sense to use node for most of applications.

[JinIgarashi]

I realized FeatureID type should be exported as well. change event of terradraw uses FeatureID type, there is an issue of defining a callback function for change event.

terra-draw/packages/terra-draw/src/terra-draw.ts

Line 35 in 5d45d40

FeatureId,

For moduleResolution setting, I found moduleResolution: bundler can work with terra-draw types. but it does not work with nodeNext

[ciscorn]

@JinIgarashi Thanks! As for FeatureID, I believe it has already been exported in this PR.

terra-draw/packages/terra-draw/src/terra-draw.ts

Line 810 in 5477d19

FeatureId,