Fix #26. Exclude 'Form' tag from ElementsFlags #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does it do exactly? Does it actually exclude all form tags and their children? I'm wary of bringing this in until I know what the output will be. Can you give some examples of the output? I don't really want to be excluding forms from the output (I'm using the jsonize library in another project that it would be really nice to have forms included in). |
|
No, it doesn't exclude all form tags. It just says to HtmlAgilityPack that form tag can not overlap other HTML elements like so: <!-- Valid HTML 3 markup -->
<div><form></div></form>
More about what it it on StackOverflow discussion or on HtmlAgilityPack repository workitem on CodePlex. With that line of code test Jsonize jsonize = new Jsonize("<html><head></head><body><form></form></body></html>");
var result = jsonize.ParseHtmlAsJsonString(jsonizeConfiguration);
/*
result:
{
"node":"Document",
"child":[
{
"tag":"html",
"child":[
{
"tag":"head"
},
{
"tag":"body",
"child":[
{
"tag":"form"
}
]
}
]
}
]
}
*/UPD: From HtmlAgilityPack sources: public partial class HtmlNode : IHtmlBaseNode
{
/// <summary>
/// Gets a collection of flags that define specific behaviors for specific element nodes.
/// The table contains a DictionaryEntry list with the lowercase tag name as the Key, and a combination of HtmlElementFlags as the Value.
/// </summary>
public static Dictionary<string, HtmlElementFlag> ElementsFlags;
// some code
static HtmlNode()
{
// ...
ElementsFlags.Add("form", HtmlElementFlag.CanOverlap | HtmlElementFlag.Empty);
// ...
}
// more code
} |
feeeper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26
As I can see it the feature of the HtmlAgilityPack (for HTML 3.2). And one of the workarounds is exclude "form" from
ElementsFlagsdictionary.