Incorrect <form> tag processing #26

feeeper · 2016-10-19T06:38:39Z

I start working on tests and found some problem (or may be I misunderstanding

tag processing).

My test:

Jsonize jsonize = new Jsonize("<html><head></head><body><form></form></body></html>");
var result = jsonize.ParseHtmlAsJsonString(jsonizeConfiguration);

Result JSON string:

{
  "node": "Document",
  "child": [
    {
      "node": "Element",
      "tag": "html",
      "child": [
        {
          "tag": "head"
        },
        {
          "node": "Element",
          "tag": "body",
          "child": [
            {
              "tag": "form"
            },
            {
              "node": "Text",
              "text": "</form>"
            }
          ]
        }
      ]
    }
  ]
}

Is it true that node "Text" with text "</form>" is not correct? And it should look so:

{
  "node": "Document",
  "child": [
    {
      "tag": "html",
      "child": [
        {
          "tag": "head"
        },
        {
          "tag": "body",
          "child": [
            {
              "tag": "form"
            }
          ]
        }
      ]
    }
  ]
}

JackWFinlay · 2016-10-19T06:42:20Z

Nice find. You are correct, the second case should be the proper result. I'll have to address that when I have some time.

Just out of curiosity, what happens when you put some elements inside the form?

feeeper · 2016-10-19T06:48:45Z

I inserted input inside the form and got the result:

{
  "node": "Document",
  "child": [
    {
      "node": "Element",
      "tag": "html",
      "child": [
        {
          "tag": "head"
        },
        {
          "node": "Element",
          "tag": "body",
          "child": [
            {
              "tag": "form"
            },
            {
              "tag": "input"
            },
            {
              "node": "Text",
              "text": "</form>"
            }
          ]
        }
      ]
    }
  ]
}

JackWFinlay · 2016-10-19T06:53:14Z

Interesting. I'll definitely have to fix that, or you can give it a go If you'd like. Thanks for spotting that. I think it may be an issue with HtmlAgilityPack. We can probably intercept it if it is form node and do some manual of our own processing.

feeeper · 2016-10-19T06:59:28Z

First of all I'll add the test for the case (today or tomorrow) :) And then I'll try to figure out what the problem.

feeeper · 2016-10-20T07:58:22Z

I send the PR for the issue.

PS: Can you add Hacktoberfest label for the issue, please?

Fix #26. Exclude 'Form' tag from ElementsFlags

feeeper pushed a commit to feeeper/jsonize that referenced this issue Oct 20, 2016

Fix JackWFinlay#26. Exclude 'From' tag from ElementsFlags

e8c65bb

feeeper mentioned this issue Oct 20, 2016

Fix #26. Exclude 'Form' tag from ElementsFlags #28

Merged

JackWFinlay added the Hacktoberfest label Oct 20, 2016

JackWFinlay closed this as completed in #28 Oct 21, 2016

JackWFinlay added a commit that referenced this issue Oct 21, 2016

Merge pull request #28 from feeeper/incorrect-form-tag-processing

a1a5b53

Fix #26. Exclude 'Form' tag from ElementsFlags

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorrect <form> tag processing #26

Incorrect <form> tag processing #26

feeeper commented Oct 19, 2016 •

edited

Loading

JackWFinlay commented Oct 19, 2016

feeeper commented Oct 19, 2016

JackWFinlay commented Oct 19, 2016

feeeper commented Oct 19, 2016

feeeper commented Oct 20, 2016

Incorrect <form> tag processing #26

Incorrect <form> tag processing #26

Comments

feeeper commented Oct 19, 2016 • edited Loading

JackWFinlay commented Oct 19, 2016

feeeper commented Oct 19, 2016

JackWFinlay commented Oct 19, 2016

feeeper commented Oct 19, 2016

feeeper commented Oct 20, 2016

feeeper commented Oct 19, 2016 •

edited

Loading