Add Add To Group action to context menu of entries #12368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for forumm issue
* upstream/main: Update abbrv.jabref.org (#12365) Bump buildres/abbrv.jabref.org from `78e1b08` to `c202741` (#12363) Bump org.beryx.jlink from 3.1.0-rc-1 to 3.1.1 (#12362) Bump tech.units:indriya from 2.2.1 to 2.2.2 (#12361) Bump com.dlsc.gemsfx:gemsfx from 2.80.0 to 2.81.0 (#12360) Bump org.mariadb.jdbc:mariadb-java-client from 2.7.9 to 2.7.12 (#12359) Bump org.mockito:mockito-core from 5.14.2 to 5.15.2 (#12358) Fix content not correctly parsed at pdf content importer (#12338) Bump de.undercouch:citeproc-java from 3.1.0 to 3.2.0 (#12347) Bump org.openrewrite.rewrite from 6.29.0 to 6.29.2 (#12345) Improve utf8 detection (#12342) Bump org.fxmisc.richtext:richtextfx from 0.11.3 to 0.11.4 (#12346) Bump ai.djl:bom from 0.30.0 to 0.31.1 (#12344) Bump com.puppycrawl.tools:checkstyle from 10.21.0 to 10.21.1 (#12343)
|
The build of this PR is available at https://builds.jabref.org/pull/12368/merge. |
LoayGhreeb
reviewed
Jan 9, 2025
| this.stateManager = stateManager; | ||
| this.dialogService = dialogService; | ||
|
|
||
| this.executable.bind(ActionHelper.needsEntriesSelected(stateManager)); |
There was a problem hiding this comment.
Should this action be disabled if entries cannot be added to the selected groups (All entries group/Search group)?
org.jabref.gui.groups.GroupNodeViewModel#canAddEntriesIn
There was a problem hiding this comment.
Yeah, this is what I thought as well. Needs some more adjustments. Was just a first quick hack yesterday evening so that the user can test
LoayGhreeb
reviewed
Jan 9, 2025
There was a problem hiding this comment.
- What about the "Remove entries from this group" option? I see in the video, It is also not accessible.
- The string "Add selected entries to this group" can be changed to "Add selected entries to the selected group(s)" since multiple groups can be selected and entries can be added to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for forum issue
https://discourse.jabref.org/t/jabref-6-0-drop-down-menu-in-groups-doesnt-close-line-item-doesnt-stay-highlighted/5336/14?u=siedlerchr
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)