-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network visualization #14
Conversation
✅ Deploy Preview for molevolvr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
55d9bbc
to
d214a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level quick look -- seems OK. I've asked a few clarifying Qs to prepare us for how this will be used within MolEvolvR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly read through the code and didn't find anything surprising; nice work!
I'll add shapes (tied to colors which are mapped to unique Also more filters can/will be added when this network component starts to be used in-situ. E.g., only show nodes with p-value between A and B. These filters will exist outside the component, since they are more specific and not generic to all use-cases of the component. That is, the sliders will be outside of the component, and the node/edge data will be filtered appropriately before being passed to the component. |
This is based off of #14 . I'll rebase it once that PR is merged so only 32e2a44 remains. - use first-party `@axe-core/playwright` instead of `axe-playwright` - add type packages for network viz layout algorithms - add dark mode toggle button and sync with local storage - add dark mode theme colors - replace a few hard-coded colors in a few spots with css theme vars - move testbed network randomized data generation outside component so it only changes on page refresh, not every component re-render - change "get css var" util funcs to be a reactive hook, which will update on dark mode toggle
Closes #6 (except for "nice to haves", which we can revisit later)