Reduce for loop complexity from O(N^2) to O(N) (#214)

* Reduce forloop complexity from N^2 to N * Reduce for loop complexity from O(N^2) to O(N)
JKorf · Jun 7, 2024 · 14cb8ac · 14cb8ac
1 parent 1ef996e
commit 14cb8ac
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/ByBit.Net/Clients/V5/BybitRestClientApiTrading.cs b/ByBit.Net/Clients/V5/BybitRestClientApiTrading.cs
@@ -139,11 +139,11 @@ public async Task<WebCallResult<IEnumerable<BybitBatchResult<BybitBatchOrderId>>
             if (result.Data.ReturnCode != 0)
                 return result.AsError<IEnumerable<BybitBatchResult<BybitBatchOrderId>>>(new ServerError(result.Data.ReturnCode, result.Data.ReturnMessage));
 
-            var resultList = new List<BybitBatchResult<BybitBatchOrderId>>();
+            var resultList = new List<BybitBatchResult<BybitBatchOrderId>>(); 
+            var resultItems = result.Data.Result.List.ToArray();
             int index = 0;
             foreach (var item in result.Data.ExtInfo.List)
-            {
-                var resultItems = result.Data.Result.List.ToArray();
+            {                
                 var resultItem = resultItems[index++];
                 resultList.Add(new BybitBatchResult<BybitBatchOrderId>
                 {
@@ -237,10 +237,10 @@ public async Task<WebCallResult<IEnumerable<BybitBatchResult<BybitBatchOrderId>>
                 return result.AsError<IEnumerable<BybitBatchResult<BybitBatchOrderId>>>(new ServerError(result.Data.ReturnCode, result.Data.ReturnMessage));
 
             var resultList = new List<BybitBatchResult<BybitBatchOrderId>>();
+            var resultItems = result.Data.Result.List.ToArray();
             int index = 0;
             foreach (var item in result.Data.ExtInfo.List)
             {
-                var resultItems = result.Data.Result.List.ToArray();
                 resultList.Add(new BybitBatchResult<BybitBatchOrderId>
                 {
                     Code = item.Code,
@@ -315,10 +315,10 @@ public async Task<WebCallResult<IEnumerable<BybitBatchResult<BybitBatchOrderId>>
                 return result.AsError<IEnumerable<BybitBatchResult<BybitBatchOrderId>>>(new ServerError(result.Data.ReturnCode, result.Data.ReturnMessage));
 
             var resultList = new List<BybitBatchResult<BybitBatchOrderId>>();
+            var resultItems = result.Data.Result.List.ToArray(); 
             int index = 0;
             foreach (var item in result.Data.ExtInfo.List)
             {
-                var resultItems = result.Data.Result.List.ToArray();
                 var resultItem = resultItems[index++];
                 resultList.Add(new BybitBatchResult<BybitBatchOrderId>
                 {