Display the data of the message when a plugin activation fails #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wordpress error message for a plugin activation is always the same:
return new WP_Error('unexpected_output', __('The plugin generated unexpected output.'), $output);
So the error message is not really helpfull
As such displaying the output there will help debuging
JDGrimes
reviewed
Apr 10, 2019
| echo "- " . $result->get_error_message( $code ) . PHP_EOL; | ||
| $data = $result->get_error_data( $code ); | ||
| if ( ! empty( $data ) && is_string( $data ) ) { | ||
| echo "Data: " . $data; |
There was a problem hiding this comment.
Thanks for the PR @Tofandel ! Sorry for the delay in reviewing it.
This looks good, except maybe there needs to be a new line output after the data. What do you think?
Suggested change
| echo "Data: " . $data; | |
| echo "Data: " . $data . PHP_EOL; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wordpress error message for a plugin activation is always the same:
return new WP_Error('unexpected_output', __('The plugin generated unexpected output.'), $output);
So the error message is not really helpfull
As such displaying the output there will help debuging
Also fix compatibility with WP4.8- and WP 5.1+ because the required file do not exist