NTSL Achievements Fix

[untrius]

About The Pull Request

It seemed suspicious that no one had either of the NTSL achievements yet, so I took a look at what the code was doing on a separate branch.

The first issue was that when checking if the player uploading the NTSL script is a Telecomms Specialist, the code was comparing the player's job datatype with the Telecomms Specialist job name string. This will always return false.

The second issue is only for the achievement for blocking Poly on comms. The intended checks for this are, to check that Poly is blocked, then check that a nameless user is not blocked. The second check had a double negation on it, so the achievement was only given if effectively all users were blocked from comms. This is clearly not the intended behavior.

Known corner case: The achievement for making Poly loud, will be awarded even if everyone on comms is made loud. While this feels against the point of the achievement, I don't think this should be prevented, as the goal was adequately satisfied.

Known Issue: The 8 servers compile the code all at the same time, before each trying to award one of the achievements. This means either achievement will be awarded 8 times. This spams chat and the End of Round Summary, but otherwise appears harmless. It does not inflate the achievement score, and it does not add extra rows to the achievements table.

I can think of 2 potential solutions:

1. Restrict the achievements to a specific radio channel. But this can cause confusion if Poly is put on a different channel, or if tcomms has been rebuilt from scratch.
2. Use a mutex so only one tcomms server is allowed to call give_award() at a time. At this time, I don't know if DM supports mutex's or how one would correctly implement their behavior in DM. I may look into this in the future.

Why it's Good for the Game

Bugfix: broken achievements are now available

Proof of Testing

I am using an alt title to prove the achievements are still awarded while using them:

Silence Bird:

NTSL Code


Embrace The Bird:

NTSL Code


Changelog

🆑
fix: NTSL achievements are now awardable
/:cl: