Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuration cache #73

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Support configuration cache #73

merged 2 commits into from
Nov 27, 2024

Conversation

tnielens-centrica
Copy link
Contributor

@tnielens-centrica tnielens-centrica commented Jan 24, 2024 •
edited
Loading

Implements #70, addresses #59.

@tnielens-centrica tnielens-centrica force-pushed the feature/configuration-cache branch 4 times, most recently from 6174963 to a8be8d6 Compare January 25, 2024 19:42
@tnielens-centrica tnielens-centrica force-pushed the feature/configuration-cache branch from a8be8d6 to 6bf2f5d Compare January 25, 2024 20:12
@tnielens tnielens mentioned this pull request Jan 29, 2024
Merged
skiesewetter-intershop
skiesewetter-intershop approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@skiesewetter-intershop skiesewetter-intershop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnielens: Thank you for your contribution.

@cschoell
Copy link

cschoell commented Jul 9, 2024

Will this be merged? It would be awesome to have a version with this fix included.

@tnielens-centrica
Copy link
Contributor Author

@skiesewetter-intershop periodical ping :)

@skiesewetter-intershop
Copy link
Contributor

Will this be merged? It would be awesome to have a version with this fix included.

@cschoell You can merge it as soon as the conflicts are resolved.

@cschoell
Copy link

Will this be merged? It would be awesome to have a version with this fix included.

@cschoell You can merge it as soon as the conflicts are resolved.

I think you meant @tnielens-centrica , right?

@skiesewetter-intershop
Copy link
Contributor

Will this be merged? It would be awesome to have a version with this fix included.

@cschoell You can merge it as soon as the conflicts are resolved.

I think you meant @tnielens-centrica , right?

@cschoell: The question "Will this be merged?" came from you.

@cschoell
Copy link

Will this be merged? It would be awesome to have a version with this fix included.

@cschoell You can merge it as soon as the conflicts are resolved.

I think you meant @tnielens-centrica , right?

@cschoell: The question "Will this be merged?" came from you.

That's true, but I don't know how I can merge it? I don't think I have the rights to do that.

@cschoell
Copy link

cschoell commented Nov 27, 2024 •
edited
Loading

It says
"Only those with [write access]to this repository can merge pull requests."

I'm not sure if @tnielens-centrica or me can merge this at all?

@tnielens-centrica
Copy link
Contributor Author

@cschoell no I'm not part of the repo maintainers, don't have that permission.

@skiesewetter-intershop skiesewetter-intershop merged commit 62b748f into IntershopCommunicationsAG:master Nov 27, 2024
1 check passed
@cschoell
Copy link

Thanks @skiesewetter-intershop :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skiesewetter-intershop skiesewetter-intershop skiesewetter-intershop approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tnielens-centrica @cschoell @skiesewetter-intershop @tnielens