#90235 - update wrapper #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade to Gradle 8.5 * usage of detekt plugin removed
skiesewetter-intershop
requested review from
DevDavido,
Thomas-Bergmann,
stefanh1,
m-raab,
SteBoe82 and
cortlepp
cortlepp
reviewed
Dec 1, 2023
cortlepp
reviewed
Dec 1, 2023
* test fixed
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
* now using our action v0.4 (build without publish)
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
* remove memory options from gradle.properties
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
cortlepp
reviewed
Dec 4, 2023
.github/workflows/release.yml
Outdated
| if: always() | ||
| - name: Setup | ||
| uses: IntershopCommunicationsAG/.github/actions/[email protected] | ||
| - name: Build |
There was a problem hiding this comment.
Please adapt the name to "Release"
cortlepp
reviewed
Dec 4, 2023
build.gradle.kts
Outdated
| @@ -278,6 +269,7 @@ dependencies { | |||
| implementation(gradleApi()) | |||
| implementation(gradleKotlinDsl()) | |||
|
|
|||
| //todo | |||
cortlepp
reviewed
Dec 4, 2023
| }) | ||
|
|
||
| systemProperty("intershop.gradle.versions","8.0.2") | ||
| systemProperty("intershop.gradle.versions","8.5") |
There was a problem hiding this comment.
If we still aim to be compatible with older versions (which should be possible since you didn't do any breaking changes) the old version should stay in there and continue to be tested against. If we don't want to stay compatible, you should also adapt the README.
* renamed pipeline step Build -> Release * use correct .github/actions versions
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
* removed obsolete "TODO"
skiesewetter-intershop
temporarily deployed
to
CIRelease
GitHub Actions
Inactive
cortlepp
approved these changes
Dec 5, 2023
DevDavido
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.