Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2920): fix unhandled exception on missing proposal for vote #2921

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix(#2920): fix unhandled exception on missing proposal for vote #2921

merged 1 commit into from
Feb 7, 2025

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix unhandled exception on missing proposal for vote

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner February 7, 2025 12:59
@MSzalowski MSzalowski linked an issue Feb 7, 2025 that may be closed by this pull request
🐛 Backend crashes when tries to fetch proposals that drep voted on that does not exist #2920
Closed
@MSzalowski MSzalowski force-pushed the fix/2920-backend-crashes-when-tries-to-fetch-proposals-that-drep-voted-on-that-does-not-exist branch from 592ca22 to 555f62a Compare February 7, 2025 13:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from placek February 7, 2025 13:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All checks succeeded

4 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 07d521b into develop Feb 7, 2025
5 of 7 checks passed
@MSzalowski MSzalowski deleted the fix/2920-backend-crashes-when-tries-to-fetch-proposals-that-drep-voted-on-that-does-not-exist branch February 7, 2025 15:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

@MSzalowski
This PR is in the tag: develop-07d521bd2b63d0eee02140e6de08a347569d53a0 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

@MSzalowski
This PR is in the tag: develop-07d521bd2b63d0eee02140e6de08a347569d53a0 , for govtool-frontend service

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

@MSzalowski
This PR is in the tag: develop-07d521bd2b63d0eee02140e6de08a347569d53a0 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Backend crashes when tries to fetch proposals that drep voted on that does not exist
2 participants
@MSzalowski @placek