Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize ledger state #4868

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Organize ledger state #4868

merged 8 commits into from
Feb 5, 2025

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 1, 2025

Description

This is the beginning of the new organization of the ledger state

This PR is based on #4867

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from a team as a code owner February 1, 2025 01:35
@lehins lehins force-pushed the lehins/organize-ledger-state branch from a96a158 to 3dc2574 Compare February 1, 2025 18:04
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, "obvious in hindsight" kind of good.

@lehins lehins force-pushed the lehins/organize-ledger-state branch from 3dc2574 to c95100b Compare February 5, 2025 20:44
@lehins lehins enabled auto-merge February 5, 2025 20:44
@lehins lehins merged commit 685f1da into master Feb 5, 2025
154 of 156 checks passed
@lehins lehins deleted the lehins/organize-ledger-state branch February 5, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants