Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped the spec to include fixes to SecurityGroup parameters #4862

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 30, 2025

Description

This PR fixes a conformance failure, which happens when an SPO tries to vote for a ParameterChange. Previously none of the parameters in the spec were in the security group, which meant that the SPOs could not vote for any protocol parameter changes.

Now that's fixed in the spec and this PR bumps the spec version to one where the security parameters are implemented properly.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw marked this pull request as ready for review January 30, 2025 13:19
@Soupstraw Soupstraw requested a review from a team as a code owner January 30, 2025 13:19
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done figuring out how to fix it!

@Soupstraw Soupstraw force-pushed the jj/security-group branch 5 times, most recently from eb2491c to a1b2938 Compare February 3, 2025 10:46
Co-authored-by: teodanciu <[email protected]>
@Soupstraw Soupstraw enabled auto-merge (rebase) February 3, 2025 16:48
@Soupstraw Soupstraw merged commit 3dd7401 into master Feb 3, 2025
153 of 156 checks passed
@Soupstraw Soupstraw deleted the jj/security-group branch February 3, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants