Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for garnix #4836

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

prepare for garnix #4836

wants to merge 1 commit into from

Conversation

dermetfan
Copy link
Contributor

Description

  • Add garnix cache to the flake nix config.
  • Add garnix.yaml that builds only .#checks.
  • Adjust the flake outputs to make garnix build everything that Hydra did.

Garnix does not build the hydraJobs output
so move them all into the checks output,
adhering to the flake output schema
because garnix does not build nested attrsets.

Note that this replaces the layout of the checks output
but it should still include all the checks that it had previously.
So no checks are removed, they just have a different name.
I hope that's ok and no checks are referred to by name somewhere.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the versioning process.
  • Version bounds in .cabal files updated when necessary
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@dermetfan dermetfan marked this pull request as ready for review January 14, 2025 20:28
@dermetfan dermetfan requested a review from a team as a code owner January 14, 2025 20:28
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. I am sure you are a ware, but Garnix is reporting "You have exhausted your monthly CI quota" on all PRs

@dermetfan
Copy link
Contributor Author

I was not aware, thank you @lehins.

Garnix does not build the `hydraJobs` output
so move them all into the `checks` output,
adhering to the flake output schema
because garnix does not build nested attrsets.
@dermetfan
Copy link
Contributor Author

Canceled auto-merge because I just talked to the garnix folks and we're out of quota for the trial, so no point in merging this if it won't be used. I'll merge if we can get some more quota.

@lehins
Copy link
Collaborator

lehins commented Jan 22, 2025

I'll merge if we can get some more quota.

Sounds good. I'll change it to draft so it doesn't get merged accidentally

@lehins lehins marked this pull request as draft January 22, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants