Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byron: Force startTime in genesis data to be strict #4574

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 27, 2024

Description

Closes #3598

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from neilmayhew and lehins August 27, 2024 15:35
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this change to get released we need a version bump. Please, bump the minor version to 1.0.2.0 and add a changelog entry about this change

@aniketd aniketd force-pushed the aniketd/byron-genesis-data-starttime-strictness branch from 41bbd6e to 962c852 Compare August 30, 2024 14:13
@aniketd
Copy link
Contributor Author

aniketd commented Aug 30, 2024

I have switched to using force and that dismissed the requirement to depend on deepseq directly. I have also updated the version and added the change-log entry.

@aniketd aniketd requested review from neilmayhew and lehins August 30, 2024 14:16
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins enabled auto-merge (squash) August 30, 2024 18:32
@lehins lehins force-pushed the aniketd/byron-genesis-data-starttime-strictness branch from 962c852 to e1043a3 Compare August 31, 2024 01:32
@lehins lehins force-pushed the aniketd/byron-genesis-data-starttime-strictness branch from e1043a3 to 60a89ca Compare August 31, 2024 04:21
@lehins lehins merged commit ae9a885 into master Aug 31, 2024
153 of 155 checks passed
@lehins lehins deleted the aniketd/byron-genesis-data-starttime-strictness branch August 31, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenesisData's FromJSON instance may be insufficiently strict, resulting in unevaluated thunks in gdStartTime
3 participants