Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENACT conformance #4565

Merged
merged 1 commit into from
Aug 29, 2024
Merged

ENACT conformance #4565

merged 1 commit into from
Aug 29, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Aug 26, 2024

Description

This PR adds conformance testing for the ENACT rule.

I had to disable conformance testing for GOV rule because a fix got merged in the spec which caused GOV tests to start failing once I updated the executable spec SRP. I've made a separate issue about this.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/enact-conformance branch 11 times, most recently from f8d95dd to 37152de Compare August 28, 2024 13:14
@Soupstraw Soupstraw marked this pull request as ready for review August 28, 2024 13:14
@Soupstraw Soupstraw force-pushed the jj/enact-conformance branch 2 times, most recently from 3055a6c to fa2e6b7 Compare August 28, 2024 13:28
@Soupstraw Soupstraw force-pushed the jj/enact-conformance branch from fa2e6b7 to c829b7e Compare August 29, 2024 09:15
@Soupstraw Soupstraw force-pushed the jj/enact-conformance branch from c829b7e to 84683b9 Compare August 29, 2024 09:16
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@lehins lehins merged commit 6a720c6 into master Aug 29, 2024
154 checks passed
@lehins lehins deleted the jj/enact-conformance branch August 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants