Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix cabal version & flake inputs #1030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 24, 2025

Changelog

- description: |
    Update nix cabal version & flake inputs
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Changes:

  • pin haskell.nix flake input to a tag - you can do nix flake update without worrying about haskell.nix upgrade biting you
  • update cabal to 3.14 to avoid building its version from source
  • update default ghc cross compilation to 9.6.6

This should also limit the number of GHC versions we're pulling into development shell. This had a side effect of breaking GHA due to running out of disk space: https://github.com/IntersectMBO/cardano-cli/actions/runs/12915728375/job/36018250466?pr=1024

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-cabal branch 5 times, most recently from b19a0fa to 37207dc Compare January 24, 2025 13:26
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-cabal branch from 37207dc to 374f124 Compare January 24, 2025 13:33
@carbolymer carbolymer marked this pull request as ready for review January 24, 2025 13:59
@carbolymer carbolymer requested review from a team as code owners January 24, 2025 13:59
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carbolymer carbolymer enabled auto-merge January 24, 2025 14:44
@carbolymer carbolymer added this pull request to the merge queue Jan 24, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
…cabal

Update nix cabal version & flake inputs
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2025
@carbolymer carbolymer added this pull request to the merge queue Jan 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants