-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nix build tools #1029
base: master
Are you sure you want to change the base?
Update nix build tools #1029
Conversation
@@ -107,8 +106,7 @@ | |||
# tools we want in our shell, from hackage | |||
shell.tools = | |||
{ | |||
# for now we're using latest cabal for `cabal haddock-project` fixes | |||
# cabal = "3.10.3.0"; | |||
cabal = "3.14.1.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- bump in GHA if nix is happy with that version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carbolymer> why this specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just the latest, to not have to build cabal ourselves from a specific commit. That was done to include a fix for haddocks building.
.github/workflows/release-upload.yml
Outdated
;; | ||
"aarch64-linux") | ||
derivation+="x86_64-linux.ghc965-aarch64-unknown-linux-musl" | ||
derivation+="x86_64-linux.ghc96-aarch64-unknown-linux-musl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- double check derivation name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carbolymer> please try the release pipeline on this branch as follows:
gh workflow run "Release Upload" -r $(git branch --show-current)
Because the HEAD of this branch has no associated tag, it will run the pipeline but not create a release, so it's a good way to test your change. See the documentation: https://github.com/IntersectMBO/cardano-cli/blob/master/.github/workflows/release-upload.yml#L28
flake.nix
Outdated
@@ -107,8 +106,7 @@ | |||
# tools we want in our shell, from hackage | |||
shell.tools = | |||
{ | |||
# for now we're using latest cabal for `cabal haddock-project` fixes | |||
# cabal = "3.10.3.0"; | |||
cabal = "3.14.1.1"; | |||
ghcid = "0.8.8"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- consider bumping other tools as well
@@ -43,7 +43,7 @@ jobs: | |||
/home/runner/.cache/hie-bios | |||
/home/runner/.cache/ghcide | |||
/home/runner/.local/state/cabal | |||
.ghc.environment.x86_64-linux-9.8.2 | |||
.ghc.environment.x86_64-linux-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
907bc52
to
31b63c5
Compare
.github/workflows/github-page.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Test the workflow manually
31b63c5
to
3e2e43f
Compare
5db0ffb
to
590084d
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist