Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelley: export {to,from}AlonzoLanguage (Plutus script language conversions) #731

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Shelley: export {to,from}AlonzoLanguage (Plutus script language conversions) #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cardano-api/src/Cardano/Api/Shelley.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ module Cardano.Api.Shelley
, PlutusScript (..)
, PlutusScriptOrReferenceInput (..)
, SimpleScriptOrReferenceInput (..)
, toAlonzoLanguage
, fromAlonzoLanguage
Comment on lines +140 to +141
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should replace those two function with Inject instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer> I disagree, I think we should keep Inject for conversions between eons; otherwise upon seeing a call to inject in the code we won't easily know what it's about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what is Inject for in general. It's used widely in ledger codebase for conversion between isomorphic types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer> is the ledger a model codebase in terms of ease-of-understanding 😉?

, toPlutusData
, fromPlutusData
, toAlonzoData
Expand Down
Loading