Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade plutus version to 1.37 #727

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Downgrade plutus version to 1.37 #727

merged 1 commit into from
Jan 15, 2025

Conversation

neilmayhew
Copy link
Contributor

@neilmayhew neilmayhew commented Jan 14, 2025 •
edited by carbolymer
Loading

cardano-node has a problem building plutus-core-1.38 on Hydra

Changelog

- description: |
    Downgrade plutus version to 1.37
  type:
  - bugfix        # related to a new release preparation

Context

We already merged a commit (09bc725) that upgraded the plutus version to 1.38. However, using this version in node causes a Hydra build failure. We therefore want to release node 10.2 with 1.37, so api has to match.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@neilmayhew
Copy link
Contributor Author

I need to check that the node is actually OK with 1.37, so I'll do an srp build of node pointing to this PR.

@neilmayhew neilmayhew marked this pull request as draft January 14, 2025 17:58
@neilmayhew neilmayhew marked this pull request as ready for review January 15, 2025 00:03
@neilmayhew
Copy link
Contributor Author

neilmayhew commented Jan 15, 2025 •
edited
Loading

Node and cli are now building with this change (via srp's). Please merge at your convenience. (I'm not authorized.)

@neilmayhew neilmayhew force-pushed the neilmayhew/plutus-downgrade branch from f452e2d to 0655972 Compare January 15, 2025 00:59
@neilmayhew neilmayhew mentioned this pull request Jan 15, 2025
Merged
3 tasks
@smelc smelc added this pull request to the merge queue Jan 15, 2025
@smelc smelc removed this pull request from the merge queue due to a manual request Jan 15, 2025
@neilmayhew @carbolymer
Downgrade plutus version to 1.37
78de9d7 
cardano-node has a problem building plutus-core-1.38 on Hydra
@carbolymer carbolymer force-pushed the neilmayhew/plutus-downgrade branch from 0655972 to 78de9d7 Compare January 15, 2025 09:51
@carbolymer
Copy link
Contributor

I've removed the release commit - it needs to be a separate PR

@carbolymer carbolymer merged commit a84e31f into master Jan 15, 2025
18 of 19 checks passed
@carbolymer carbolymer deleted the neilmayhew/plutus-downgrade branch January 15, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilmayhew @carbolymer @smelc