Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify EraInEon to take fewer constraints #316

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    Simplify `EraInEon` to take fewer constraints
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 14, 2023 06:40
@newhoggy newhoggy force-pushed the newhoggy/simplify-EraInEon branch from d30c1ad to 54068cb Compare October 14, 2023 06:59
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you notice that you could do this?

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. I think I've left that constraint accidentally when experimenting with Show instances.

@newhoggy newhoggy force-pushed the newhoggy/simplify-EraInEon branch from 54068cb to 8f0ec32 Compare November 16, 2023 11:25
Copy link

github-actions bot commented Jan 1, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jan 1, 2024
Copy link

github-actions bot commented Mar 2, 2024

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Mar 2, 2024
@carbolymer carbolymer reopened this Mar 4, 2024
@carbolymer carbolymer force-pushed the newhoggy/simplify-EraInEon branch from 8f0ec32 to 880c0b9 Compare March 4, 2024 10:55
@carbolymer carbolymer enabled auto-merge March 4, 2024 10:55
@carbolymer carbolymer added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 0453c31 Mar 4, 2024
23 checks passed
@carbolymer carbolymer deleted the newhoggy/simplify-EraInEon branch March 4, 2024 13:51
@carbolymer carbolymer mentioned this pull request Mar 7, 2024
3 tasks
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants