Scroll the user to the comments section when accepting/denying a request #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenny2github
requested changes
Apr 20, 2023
| @@ -96,11 +96,17 @@ function isCSRF(&$session, $csrftoken) { | |||
| * @param username The Scratch username whose profile is being linked to | |||
| * @return string A simple <a> link to the user's profile with the contents also being the username | |||
| */ | |||
| function linkToScratchProfile(string $username) : string { | |||
| function linkToScratchProfile(string $username, bool $scrollToComments) : string { | |||
There was a problem hiding this comment.
This parameter is not used by anything.
There was a problem hiding this comment.
yeah, that was what i realised after making the pr, but i'm not sure where this function is called when the page opens in a new tab after selecting "submit"... :/
Kenny2github
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.