Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CraftJob return #704

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Jan 23, 2025

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

  • Other information:

@zyxkad zyxkad requested a review from SirEndii January 23, 2025 00:47

IGrid grid = node.getGrid();
if (grid == null) { //true when the block is not connected
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AE2 source code prevent getGrid to return a null, I didn't check the version above 1.19.2 tho.

    @Override
    public IGrid getGrid() {
        if (this.myGrid == null) {
            throw new IllegalStateException("A node is being used after it has been destroyed.");
        }
        return this.myGrid;
    }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 3e8bb9a
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/12920550590
Jar Files AdvancedPeripherals PR 704
Expires At 2025-04-23T01:42:27Z

@SirEndii
Copy link
Member

Big thank you
This is still a prototype and I will maybe rewrite some of that stuff while abstracting all of this

@SirEndii SirEndii merged commit fb6ced2 into IntelligenceModding:dev/0.8-bridges Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants