Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change config type from common to server #703

Open
wants to merge 2 commits into
base: dev/0.8
Choose a base branch
from

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Jan 21, 2025

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Actually, idk.

  • What is the current behavior? (You can also link to an open issue here)
    Config cannot be world specific #693

  • What is the new behavior (if this is a feature change)?
    Config now will generate in saves/<world name>/serverconfig/ instead of a global instance locate at config/.
    Server location also changed to world/serverconfig/

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Yes, people need copy their configs to the serverconfig folder if they want use same config for their world.

  • Other information:

to allow each save has its own config values

close IntelligenceModding#693
@zyxkad zyxkad requested a review from SirEndii January 21, 2025 23:12
@zyxkad zyxkad linked an issue Jan 21, 2025 that may be closed by this pull request
@zyxkad zyxkad added this to the 0.8r milestone Jan 21, 2025
@zyxkad zyxkad added the 1.19x label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 72409f6
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/12897682957
Jar Files AdvancedPeripherals PR 703
Expires At 2025-04-21T23:15:34Z

@SirEndii
Copy link
Member

man I hate the config system in 1.20.4 and lower
Neoforge added a new way for defaultconfigs. We still have our configs in the normal config folder(no stupid serverconfigs folder per world) and if we want a config per world, we just copy that config into the defaultconfigs folder

I will review your PR today or tomorrow and test something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Config cannot be world specific
2 participants