-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CC Networking Cable p2p tunnel #702
Conversation
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
I'm marking this as draft because it needs more test on edge cases. |
src/main/java/de/srendi/advancedperipherals/common/addons/ae2/WiredCableP2PTunnelPart.java
Show resolved
Hide resolved
So I tried to check how AE2 adds the item model |
peripheral_detach event will be trigger twice when ME network shutdown somehow
src/main/java/de/srendi/advancedperipherals/common/data/ItemTagsProvider.java
Outdated
Show resolved
Hide resolved
Currently if you change the ME network (e.g. place one more cell/cable), existing peripherals will always detach and reattach. |
@@ -67,4 +69,11 @@ public void commonSetup(FMLCommonSetupEvent event) { | |||
}); | |||
} | |||
|
|||
public void onLoadComplete(FMLLoadCompleteEvent event) { | |||
event.enqueueWork(() -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we maybe want to put this into the APAddons class or into the Integration class direclty
Do we even need a Integration
class if the run method is not used? Maybe we want to re-organize that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to do that in Integration.run(), but Integration runs before items get registered...
I'll move them to Registries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is weird
Should happen after item registration
AdvancedPeripherals/src/main/java/de/srendi/advancedperipherals/common/setup/APRegistration.java
Line 48 in 016c6c2
CCRegistration.register(); |
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the new behavior (if this is a feature change)?
Register AE2 p2p cable to forward cc:t connections
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
No
Other information:
P2P tunnel item module is required
close IntelligenceModding/Advanced-Peripherals-Features#104