Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Automata Turtle fixes #701

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

CrazyDev05
Copy link
Contributor

@CrazyDev05 CrazyDev05 commented Jan 19, 2025

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    This fixes the following things:
  1. NullPointerException when using useOnBlock
  2. not using the actual hit vector for block interactions
  3. not saving warp points
  • What is the current behavior? (You can also link to an open issue here)
  1. NullPointerException when using useOnBlock #699
  2. It uses the block position in the hit result for interactions
  3. not saving warp points
  • What is the new behavior (if this is a feature change)?
  1. If a block was hit calculate the actual hit vector and use this for the result.
    In case that fails fall back to the block position
  2. save the compound tag after editing the points
  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    No

  • Other information:

@zyxkad zyxkad linked an issue Jan 19, 2025 that may be closed by this pull request
@SirEndii SirEndii changed the title Dev/1.21.1 Several Automata Turtle fixes Jan 20, 2025
@SirEndii SirEndii merged commit d19de49 into IntelligenceModding:dev/1.21.1 Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when using useOnBlock
2 participants