Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/lite 1.19.2 #682

Open
wants to merge 23 commits into
base: release/lite-1.19.2
Choose a base branch
from

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Jan 11, 2025

Only kept vanilla integrations, chunky turtle & compass turtle

@zyxkad zyxkad requested a review from SirEndii January 11, 2025 01:14
pull_request_target -> pull_request
@SirEndii
Copy link
Member

I've started the game just to see what exactly is changed before I do a bigger code review (when I have more time)

So you changed the modid, but not the name, do we ant to do that?
There seems to be a second AP mod in the client but without an actual mod?

image

And how do we want to version this. Should we stay at 0.7.38, should it begin at 0.7.0 or do we want a completely different versioning? So we would start at 0.1 or maybe directly 1.0 since the lite version would not contain any of the 0.8 features or other stuff

@SirEndii
Copy link
Member

And do we maybe want to release a 1.18.2 version too?

@zyxkad
Copy link
Collaborator Author

zyxkad commented Jan 11, 2025

There seems to be a second AP mod in the client but without an actual mod?

Yes, this is uses for register chunk ticket, and be able to migrate easily

@zyxkad
Copy link
Collaborator Author

zyxkad commented Jan 11, 2025

And do we maybe want to release a 1.18.2 version too?

I wants to see if 1.19.2 works well, and if it is then I can port it to 1.16-1.18.

@zyxkad
Copy link
Collaborator Author

zyxkad commented Jan 11, 2025

And how do we want to version this. Should we stay at 0.7.38, should it begin at 0.7.0 or do we want a completely different versioning? So we would start at 0.1 or maybe directly 1.0 since the lite version would not contain any of the 0.8 features or other stuff

Just for easy management I'd keep the version same, but only bump the version if main branch is updating on related logics. And player will get same result for same version of mod

Other mods should not dependent on the lite version mod, since its API may be removed/changed if its unnecessary.

@SirEndii
Copy link
Member

There seems to be a second AP mod in the client but without an actual mod?

Yes, this is uses for register chunk ticket, and be able to migrate easily

Alright I understand

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 7f645d2
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/12839888224
Jar Files AdvancedPeripherals PR 682
Expires At 2025-04-18T02:08:26Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants