Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make overloads and intrinsic target specific #1269

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Make overloads and intrinsic target specific #1269

merged 4 commits into from
Jan 5, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jan 5, 2024

Make overloads and intrinsic target specific, so we don't accidentally break numba.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jan 5, 2024
@ZzEeKkAa ZzEeKkAa changed the title Feature/set overaloads target specific Make overloads and intrinsic target specific Jan 5, 2024
@diptorupd
Copy link
Contributor

Overall the changes make sense and I am happy that we finally got it to work. We need some test cases though.

a) Something like calling dpnp.empty inside numba.njit should raise some error from Numba about unrecognized function.
b) Checking the function definitions for dpjit target context to see if these functions are available.
c) A negative test that these functions are not available in the BaseContext function definitions.

Also, do note that intrinsics ignore the target keyword so they will be available in BaseContext.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/set_overaloads_target_specific branch from f13890e to 4242584 Compare January 5, 2024 22:12
diptorupd
diptorupd approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa force-pushed the feature/set_overaloads_target_specific branch from 1e45b5b to 011675c Compare January 5, 2024 22:32
@diptorupd diptorupd merged commit 8c3cbed into main Jan 5, 2024
29 checks passed
@diptorupd diptorupd deleted the feature/set_overaloads_target_specific branch January 5, 2024 23:26
github-actions bot added a commit that referenced this pull request Jan 5, 2024
@github-actions
Merge pull request #1269 from IntelPython/feature/set_overaloads_targ…
625b470 
…et_specific

Make overloads and intrinsic target specific 8c3cbed
github-actions bot added a commit to diptorupd/numba-dpex that referenced this pull request Jan 8, 2024
@github-actions
Merge pull request IntelPython#1269 from IntelPython/feature/set_over…
8c62fc3 
…aloads_target_specific

Make overloads and intrinsic target specific 8c3cbed
github-actions bot added a commit that referenced this pull request Jan 9, 2024
@github-actions
Merge pull request #1269 from IntelPython/feature/set_overaloads_targ…
057399f 
…et_specific

Make overloads and intrinsic target specific 8c3cbed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@chudur-budur chudur-budur Awaiting requested review from chudur-budur

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd