Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/switch to dpex target context #1266

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Feature/switch to dpex target context #1266

merged 3 commits into from
Jan 4, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jan 4, 2024 •
edited by diptorupd
Loading

Enables dpjit target specific context for dpjit target.

These changes unblocks:

  • target specific overloads
  • dlpack argument overloads
  • simplification of experimental kernel (we can get use of dpexrt attribute)

Since this PR switches to dpex specific target context, that means that target specific pipelines pass are applied for all compilations including overloads. That reveals issue with parfor_legalization_cfd_pass. Current solution works ok, but does not perform assertion. That happens because we are using undocumented API there and this assertion required to spot those changes in numba's API.

Closes #1027

Checklist

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jan 4, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/switch_to_dpex_target_context branch from cdae5a9 to dc4eec5 Compare January 4, 2024 20:29
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review January 4, 2024 20:36
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner January 4, 2024 20:36
@ZzEeKkAa ZzEeKkAa force-pushed the feature/switch_to_dpex_target_context branch from dc4eec5 to 762b9a7 Compare January 4, 2024 21:04
diptorupd
diptorupd approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work to tie these loose ends and move the dpjit target work towards completion. Thank you!

@diptorupd diptorupd merged commit 71fd572 into main Jan 4, 2024
29 checks passed
@diptorupd diptorupd deleted the feature/switch_to_dpex_target_context branch January 4, 2024 21:45
github-actions bot added a commit that referenced this pull request Jan 4, 2024
@github-actions
Merge pull request #1266 from IntelPython/feature/switch_to_dpex_targ…
fd0b910 
…et_context

Feature/switch to dpex target context 71fd572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd