Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for dpnp.linspace() #1220

Closed

Conversation

chudur-budur
Copy link
Contributor

This is a WIP for overload implementation of dpnp.linspace()
This is based on #1144

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch 6 times, most recently from f08888d to fa0f4fb Compare November 22, 2023 21:44
@chudur-budur chudur-budur marked this pull request as ready for review November 23, 2023 03:00
@chudur-budur chudur-budur self-assigned this Nov 23, 2023
@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch 2 times, most recently from 708d5fa to 24dff92 Compare November 28, 2023 04:58
@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch 6 times, most recently from a100373 to 50ee93f Compare December 12, 2023 22:03
@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch 3 times, most recently from 2707fbc to 5f5de6b Compare December 20, 2023 17:27
@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch 3 times, most recently from 4961094 to 6872ed0 Compare January 14, 2024 22:34
@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch 2 times, most recently from 2b6f009 to 758e4e8 Compare January 23, 2024 02:57
…pointer

Stop type instantiation during the compilation of hpp files

Fixed SequenceStepFunctor
Dispatch vectors are correctly populated during the import of
numba_dpex.

add_sycl_to_target() must come after python_add_library()
Do not sort includes

Partially functional overload

Use correct ISO C types and added debug print
chudur-budur and others added 15 commits February 7, 2024 13:16
Better error message

Functional dpnp.arange for int and double types
Add license

pycqa --> PyCQA

Add license

Fully functional dpnp.arange without complex number support
Adding more tests

Failing on Float <- Integer case, fixing it.
Fix for windows: IntelDPCPP vs. IntelSYCL

Revert changes

Fix for coveralls.io

Fix
Fix pre-commit

Fix unbound LD_LIBRARY_PATH problem

Supply cmake compiler selections in SKBUILD_ARGS

Re-adding compiler selections in setup.py

Try with export CC and CXX

icx and icpx need to be set in setup.py, and icpx==icx for windows

Remove demangling function and debug print

Use uintN_t instead of u_intN_t

uint --> unsigned int, for windows

Set inferered dtype to default bitwidth instead of highest bitwidth

Again try with setting cc and cxx through build.*

Smart append LD_LIBRARY_PATH

Set cc and cxx in converage.yml
Added #define __API_H__

Added all C/C++ docs.

Finished python docs.

Remove SortIncludes in .clang-format

Addressed review comments.
Suppress pylint error message

Add .pylintrc, allow TODO: and FIXME: in docstring

Allow non-snake-case variable names

Fix stub names

Use bool type instead of uint8_t

Clean up code
Add _get_xfail_test() to _helper.py

_is_type() --> _match_type()

Fix docstring

Set CMAKE_C##_COMPILER in setup.py

Revert setup.py
Fix 'SYCL feature test compile failed' problem

Added overload and intrinsic functions for dpnp.linspace()
@chudur-budur chudur-budur force-pushed the feature/dpnp-linspace branch from 758e4e8 to acfc7cb Compare February 7, 2024 19:17
@diptorupd
Copy link
Contributor

Thank you @chudur-budur!

As discussed, we will explore the route of adding support for dpnp constructors using overload that are implemented as kernels. Thus, I am closing this PR.

@diptorupd diptorupd closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants