Rudimentary implementation of "uptime" filter #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't going to work. Sure, if you add an "uptime>1" requirement to a filter, it won't match until the resource has been up for an hour, but it also won't match when it's stopped (so the resource won't get started). |
|
OK, so if the "uptime" filter returns True if the resource is anything but "running", and only in that state compares the actual uptime to the configured value. This would mean that, when stopped (or starting) the filter continues to match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #366 - supports:
uptime: between xxx and yyyUptime is in hours, and is only really applicable for EC2 instances. For RDS instances, it currently uses the "time since create", since that's all that's available.