Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly observe parent directory for empty files #1295

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion kDrive/UI/Controller/Files/File List/FileListViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class FileListViewModel: SelectDelegate {
}

var realmObservationToken: NotificationToken?
var currentDirectoryObservationToken: NotificationToken?

var currentDirectory: File
var driveFileManager: DriveFileManager {
Expand Down Expand Up @@ -226,10 +227,28 @@ class FileListViewModel: SelectDelegate {
files = resultFiles
isShowingEmptyView = shouldShowEmptyView()
}

currentDirectoryObservationToken?.invalidate()
guard currentDirectory.isManagedByRealm,
!currentDirectory.isInvalidated,
let liveCurrentDirectory = currentDirectory.thaw() else { return }
currentDirectoryObservationToken = liveCurrentDirectory
.observe(keyPaths: ["lastCursor", "fullyDownloaded"],
on: .main) { [weak self] change in
guard let self else { return }

switch change {
case .change:
currentDirectory = getRefreshedCurrentDirectory()
isShowingEmptyView = shouldShowEmptyView()
default:
break
}
}
}

func shouldShowEmptyView() -> Bool {
currentDirectory.children.isEmpty && currentDirectory.fullyDownloaded
files.isEmpty && currentDirectory.fullyDownloaded
}

func startObservation() {
Expand Down
Loading