Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Realm accessed from the wrong thread #1293

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: Realm accessed from the wrong thread #1293

merged 1 commit into from
Sep 18, 2024

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Sep 17, 2024 •
edited by PhilippeWeidmann
Loading

Sentry id KDRIVE-IOS-9PM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adrien-coye adrien-coye added the bug Something isn't working label Sep 17, 2024
@PhilippeWeidmann
Copy link
Member

PhilippeWeidmann commented Sep 18, 2024 •
edited
Loading

Not sure this will work every time. I think we have something fundamentally broken with notify/observe. Will discuss in DM.

Edit: All good notify/observe correctly freezes the file. It was currentFile which wasn't on the right thread.
I'm approving the PR. However we could maybe freeze all our files before sending them to the preview as after a notify they will end up frozen anyway?

@PhilippeWeidmann PhilippeWeidmann self-requested a review September 18, 2024 06:09
@PhilippeWeidmann PhilippeWeidmann merged commit 116f353 into master Sep 18, 2024
4 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fix-realm-access branch September 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-coye @PhilippeWeidmann